Add applicationName to ServiceOptions, set user agent accordingly in Storage #307

mziccard · 2015-10-29T15:46:14Z

This PR follows from #278.
Add an applicationName getter to ServiceOptions that returns the app name in the format gcloud-java/[version].
gcloud-java is hardcoded while [version] is read from the gcloud-java-core jar's manifest.
This PR also sets storage requests' user agent accordingly.

@aozarov Is this how you expected the version to be read? I am not sure it is worth it (when compared to using a constant we update in utilites/update_xxx_version.sh).

aozarov · 2015-10-29T16:22:28Z

Yes, I think this is great (and when it would matter we can even slightly change it, so each service could, potentially, get its own version by passing its artificatId). We already have the manifest include the version, so why not use it...

Add applicationName to ServiceOptions, set user agent accordingly in Storage

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9

…13.5 (#307) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.13.4` -> `2.13.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.13.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.13.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.13.5/compatibility-slim/2.13.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.13.5/confidence-slim/2.13.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.13.5`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2135-httpsgithubcomgoogleapisjava-bigquerycomparev2134v2135-2022-06-23) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.13.4...v2.13.5) ##### Dependencies - update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#2128](https://togithub.com/googleapis/java-bigquery/issues/2128)) ([3043533](https://togithub.com/googleapis/java-bigquery/commit/3043533608c5659be0313f1942d20314d2157fd4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…o v1.3.5 (#307) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-gkehub](https://togithub.com/googleapis/java-gkehub) | `1.3.4` -> `1.3.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-gkehub/1.3.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-gkehub/1.3.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-gkehub/1.3.5/compatibility-slim/1.3.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-gkehub/1.3.5/confidence-slim/1.3.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-gkehub).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-api-gateway/compare/v2.3.5...v2.3.6) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#307](https://togithub.com/googleapis/java-api-gateway/issues/307)) ([5d6fb90](https://togithub.com/googleapis/java-api-gateway/commit/5d6fb90498d7e1953a4c6dc6615be36ad5118b58)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.6](https://togithub.com/googleapis/java-service-usage/compare/v2.3.5...v2.3.6) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#306](https://togithub.com/googleapis/java-service-usage/issues/306)) ([f932a5c](https://togithub.com/googleapis/java-service-usage/commit/f932a5cfdf98a9fd5dca78b2db0f0f7c1c54040a)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…identities to v1.1.6 (#307) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-managed-identities](https://togithub.com/googleapis/java-managed-identities) | `1.1.5` -> `1.1.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-managed-identities/1.1.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-managed-identities/1.1.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-managed-identities/1.1.6/compatibility-slim/1.1.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-managed-identities/1.1.6/confidence-slim/1.1.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-managed-identities).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-stub](https://togithub.com/grpc/grpc-java) | `1.44.1` -> `1.45.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-stub/1.45.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-stub/1.45.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-stub/1.45.0/compatibility-slim/1.44.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-stub/1.45.0/confidence-slim/1.44.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.45.0`](https://togithub.com/grpc/grpc-java/releases/v1.45.0) #### gRPC Java 1.45.0 Release Notes ##### Bug Fixes - rls: fix child lb leak when client channel is shutdown ([#8750](https://togithub.com/grpc/grpc-java/issues/8750)) - rls: fix RLS lb policy name ([#8867](https://togithub.com/grpc/grpc-java/issues/8867)) - testing: fix GrpcCleanupRule issue when retrying tests ([#8918](https://togithub.com/grpc/grpc-java/issues/8918)) - xds: fix validation code to accept new-style CertificateProviderPluginInstance ([#8892](https://togithub.com/grpc/grpc-java/issues/8892)) - xds: fix a concurrency issue in CSDS ClientStatus responses ([#8795](https://togithub.com/grpc/grpc-java/issues/8795)) - bom: Include grpc-binder - binder: Fix a ServiceConnection leak ([#8861](https://togithub.com/grpc/grpc-java/issues/8861)) - binder: Increase fairness across streams when limited by flow control. This can dramatically reduce latency when channel is being used for high throughput ([#8835](https://togithub.com/grpc/grpc-java/issues/8835)) - android: fix for app coming to foreground ([#8855](https://togithub.com/grpc/grpc-java/issues/8855)) ##### Behavior Changes - Local-only transparent retry is (practically) unlimited now. Previously it was at most once per RPC. - xds: implement least_request load balancing policy ([#8739](https://togithub.com/grpc/grpc-java/issues/8739)) ##### Dependencies - Bump Error Prone Annotations to 2.10.0 - Bump Guava to 31.0.1-android - Bump Google Auth Library to 1.4.0 - Bump Auto Value to 1.9 - netty: Include both x86 and Arm64 epoll as dependency for grpc-netty-shaded - testing: remove opencensus dependency from grpc-testing ([#8833](https://togithub.com/grpc/grpc-java/issues/8833)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

🤖 I have created a release *beep* *boop* --- ### [1.2.9](googleapis/java-iam@v1.2.8...v1.2.9) (2022-03-09) ### Dependencies * update dependency io.grpc:grpc-stub to v1.45.0 ([#307](googleapis/java-iam#307)) ([bb57ef1](googleapis/java-iam@bb57ef1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Add applicationName to Options, set user agent accordingly in Storage

f0fe56a

mziccard added api: core api: storage Issues related to the Cloud Storage API. labels Oct 29, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2015

aozarov added a commit that referenced this pull request Oct 29, 2015

Merge pull request #307 from mziccard/add-options-get-app-name

ec10ca6

Add applicationName to ServiceOptions, set user agent accordingly in Storage

aozarov merged commit ec10ca6 into googleapis:master Oct 29, 2015

This was referenced Oct 29, 2015

We should set ServiceOptions.applicationName as the user-agent in Datastore requests. #308

Closed

Where do we set the user agent in the request? #278

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add applicationName to ServiceOptions, set user agent accordingly in Storage #307

Add applicationName to ServiceOptions, set user agent accordingly in Storage #307

mziccard commented Oct 29, 2015

aozarov commented Oct 29, 2015

Add applicationName to ServiceOptions, set user agent accordingly in Storage #307

Add applicationName to ServiceOptions, set user agent accordingly in Storage #307

Conversation

mziccard commented Oct 29, 2015

aozarov commented Oct 29, 2015